fix: asset file extension detection

php-internal · Jul 20, 2024 · e172dd9 · e172dd9
1 parent df800ce
commit e172dd9
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 5 deletions.
diff --git a/src/Module/Repository/Collection/AssetsCollection.php b/src/Module/Repository/Collection/AssetsCollection.php
@@ -44,11 +44,16 @@ public function whereOperatingSystem(OperatingSystem $os): self
     public function whereFileExtensions(array $extensions): self
     {
         return $this->filter(
-            static fn(AssetInterface $asset): bool => \in_array(
-                \pathinfo($asset->getName(), \PATHINFO_EXTENSION),
-                $extensions,
-                true,
-            ),
+            static function (AssetInterface $asset) use ($extensions): bool {
+                $assetName = \strtolower($asset->getName());
+                foreach ($extensions as $extension) {
+                    if (\str_ends_with($assetName, '.' . $extension)) {
+                        return true;
+                    }
+                }
+
+                return false;
+            },
         );
     }
 

diff --git a/tests/Unit/Module/Common/ArchitectureTest.php b/tests/Unit/Module/Common/ArchitectureTest.php
@@ -17,6 +17,7 @@ public static function provideBuildNames(): iterable
         yield ['temporal_cli_0.13.2_windows_aaamd64.tar.gz', null];
         yield ['temporal_cli_0.13.2_windows.amd644.tar.gz', null];
         yield ['roadrunner-2024.1.5-windows.zip', null];
+        yield ['roadrunner-2024.1.5-linux-amd64.deb', Architecture::X86_64];
     }
 
     #[DataProvider('provideBuildNames')]

diff --git a/tests/Unit/Module/Common/OperatingSystemTest.php b/tests/Unit/Module/Common/OperatingSystemTest.php
@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Internal\DLoad\Tests\Unit\Module\Common;
+
+use Internal\DLoad\Module\Common\OperatingSystem;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+
+class OperatingSystemTest extends TestCase
+{
+    public static function provideBuildNames(): iterable
+    {
+        yield ['roadrunner-2024.1.5-windows-amd64.zip', OperatingSystem::Windows];
+        yield ['temporal_cli_0.13.2_windows_amd64.tar.gz', OperatingSystem::Windows];
+        yield ['roadrunner-2024.1.5-linux-amd64.deb', OperatingSystem::Linux];
+        yield ['roadrunner-2024.1.5-linux-amd64.tar.gz', OperatingSystem::Linux];
+        yield ['roadrunner-2024.1.5-unknown-musl-amd64.tar.gz', null];
+    }
+
+    #[DataProvider('provideBuildNames')]
+    public function testTryFromBuildName(string $name, ?OperatingSystem $expected): void
+    {
+        self::assertSame($expected, OperatingSystem::tryFromBuildName($name));
+    }
+}