Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have grepped the stub files of master, and besides
Deprecated
attributes, which I've ignored for now, only found a couple of attributes.So now we have:
Great! Even linking works. However, two paragraphs above:
Hmm.
We also have:
No linking (yet), but okay for now. Should only
Attribute
be linked, or alsoAttribute::TARGET_CLASS
?And now:
Okay, there is a scroll bar at the bottom of the classsynopsis, and the view width isn't up to modern standards (maybe), but this doesn't look great. What to do here? Leave as is? More line breaks? Skip the
Attribute::
"prefix"? The latter would look likeAnd how to handle
Deprecated
. We already have prominent warnings about deprecations, and even versions.xml allows to specify that. Still add the attribute?It seems to me that before even implementing documentation support for attributes in gen_stub.php, we need to figure out the details. Suggestions welcome!