Fix #12 memory leak in dio_read

php · Jan 23, 2024 · e040398 · e040398
1 parent 3fd676e
commit e040398
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/php7/dio.c b/php7/dio.c
@@ -208,10 +208,9 @@ PHP_FUNCTION(dio_read)
 		RETURN_NULL();
 	}
 
-	data = erealloc(data, res + 1);
 	data[res] = 0;
 
-	RETURN_STRINGL(data, res);
+	RETVAL_STRINGL(data, res);
 	efree(data);
 }
 /* }}} */

diff --git a/tests/gh12.phpt b/tests/gh12.phpt
@@ -0,0 +1,26 @@
+--TEST--
+GH-12: Memory leak in dio_read
+--SKIPIF--
+<?php
+if (!extension_loaded("dio")) print "skip";
+if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') print "skip Linux only";
+?>
+--INI--
+memory_limit=10M
+--FILE--
+<?php
+file_put_contents(__DIR__ . '/dio-test-file', str_repeat('0', 10 * 1024));
+$hFile = dio_open(__DIR__ . '/dio-test-file', O_RDONLY);
+
+for($i=0 ; $i<10000; $i++) {
+	dio_seek($hFile, 0);
+	$data = dio_read($hFile, 10000);
+}
+?>
+Done
+--CLEAN--
+<?php
+@unlink(__DIR__ . '/dio-test-file');
+?>
+--EXPECT--
+Done