-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Windows binaries to Release #13
base: master
Are you sure you want to change the base?
Conversation
Well, usually the releases are published on PECL, and there are DLLs available (again), so this just might be confusing to users. |
I don't see any problem with publishing the binaries here as well. |
A standardized build system for PHP and all extensions is what https://github.com/php/php-windows-builder is all about: use the same version of toolset (compiler, linker, etc.), Windows SDK, and dependencies (which ideally should have also been built with these versions), and what not, to build PHP core and all public extensions. And, if need be, be able to quickly rebuilt all that stuff. In my opinion, it is fine to upload Windows build artifacts for pushes and pull requests, so users can test whether a certain commit actually fixes their problems (or whether a certain new feature actually meets their expectation), but DLLs used in production should better come from a central place. |
I didn't know about the standardized action for building php and extensions. |
As far as I can see, there is still a long way to go in terms of standardizing the construction method.
|
Please consider to file a ticket at https://github.com/php/php-windows-builder. |
Added four steps in windows build and test:
Here you can see what a Release would look like:
https://github.com/alphp/pecl-system-dio/releases/tag/0.3.0