Upgrade flysystem v2 #1198
Merged
Upgrade flysystem v2 #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
force-pushed
the
upgrade-flysystem-v2
branch
6 times, most recently
from
e9dd577 to
ce3ee26
Compare
|
@linawolf, I would like to hear what you think about these changes, please do NOT update the branch as a lot of composer steps have been taken by me. I will take care of merging when we agree this is a path we should take. I think this path will also allow us to get files outside the documentation directory for typo3 projects, by replacing flysystem with another filesystem like symfony/filesystem for example. |
jaapio
force-pushed
the
upgrade-flysystem-v2
branch
from
ce3ee26 to
d3bd002
Compare
The filesystem component makes an abstraction between guides and flysystem. This makes it easier to maintain the project when external dependencies are introducing breaking changes. The filesystem component is just focused on the needs of phpDocumentor and shall not be seen as a stand alone component to be used by other projects.
jaapio
force-pushed
the
upgrade-flysystem-v2
branch
from
d3bd002 to
b281d2d
Compare
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to abstract away the logic provided by FlySystem. FlySystem has some challenges when updating, but also limits the way filesystems are implemented in this project. By adding a new package we can migrate to a new version of flysystem, and even introduce other file system adapters when people want to use a different system. Although the latter requires some extra work to allow people to use the flysystem based file finder.
The new system has been implemented in a backward compatible way, so other projects depending on this project can migrate when they are ready.