-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Introduce NavigationTitle #871
Conversation
ed5812c
to
86a19e1
Compare
2d1c796
to
7ed6814
Compare
In some spots this feels like a dirty hack, I see that you are using a field to set the alternative navigation title. That looks good. what feels wrong is that we need an extra option in the DocumentEntry. I would expect the same approach as for the breadcrumbs where you chose on rendering the different title. I think we should do the same for menu's. The document node should not be aware of the existing extra title. Maybe we should have an extra map where you can do the title lookup to make it easier. we could build that map during the compilingpass and use that during the rendering phase. I hope this makes sense? Let's discuss the details if you want to know more. |
7ed6814
to
7357983
Compare
7357983
to
1b7eab2
Compare
@jaapio how would you feel about this solution, where I keep the data in a map and make it extendable by event? |
57c7e18
to
73f4cda
Compare
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
In TYPO3 we often have the problem, that longer titles are required for search engines, our internal search and for ppl coming from by direkt link out of context. However long titles clutter up the menues and cause a lot of repetition there.
So we would like to be able to give Documents a short title for the Menu and a longer one to display in place.
This is not a sphinx feature, it is however hard to impossible to do in a theme