Fix hover on namespaced function

phpactor · Dec 27, 2020 · 817179b · 817179b
1 parent 3265e50
commit 817179b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/LanguageServerHover/Handler/HoverHandler.php b/lib/LanguageServerHover/Handler/HoverHandler.php
@@ -175,7 +175,7 @@ private function renderMember(SymbolContext $symbolContext): string
 
     private function renderFunction(SymbolContext $symbolContext): string
     {
-        $name = $symbolContext->symbol()->name();
+        $name = $symbolContext->name();
         $function = $this->reflector->reflectFunction($name);
 
         return $this->renderer->render(new HoverInformation($name, $function->docblock()->formatted(), $function));

diff --git a/tests/LanguageServerCompletion/Unit/Handler/HoverHandlerTest.php b/tests/LanguageServerCompletion/Unit/Handler/HoverHandlerTest.php
@@ -84,5 +84,15 @@ private function f<>oo():string {}
             '<?php cl<>ass A { } }',
             'A'
         ];
+
+        yield 'function' => [
+            '<?php function foo() {} f<>oo();',
+            'A'
+        ];
+
+        yield 'namespaced function' => [
+            '<?php namespace Barf {function foo() {}} Barf\f<>oo();',
+            'A'
+        ];
     }
 }