Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation with Symfony 7 #18

Closed
wants to merge 1 commit into from

Conversation

alexander-schranz
Copy link
Contributor

No description provided.

@dbu
Copy link
Member

dbu commented Feb 20, 2024

in sync with the other upgrades, i suggest we move to php ^8.1

and about prophecy: i am not attached to it. maybe its easiest to replace it with normal phpunit mocks.

@alexander-schranz
Copy link
Contributor Author

I mostly use prophesize. But if possible I would even like to avoid any mocks :)

@dbu
Copy link
Member

dbu commented Feb 20, 2024

if we can avoid the mocks, all the better. and i don't mind either way with prophesize.

@dbu
Copy link
Member

dbu commented Mar 16, 2024

wrapping up in #20

turns out prophesize was only used to create mocks, which phpunit's own createMock can do just as well.

@dbu dbu closed this Mar 16, 2024
@alexander-schranz alexander-schranz deleted the patch-1 branch March 16, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants