Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces page - Tweak margin and padding to achieve better indentation alignment #3201

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Adjust the alignment in Interfaces page.

Currently the list indentation is too small and looks misaligned.

How does this PR accomplish the above?

Adjusting the options to fix padding and margin used to indent the list.

tweak_interfaces_alignment


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign
Copy link
Member Author

Note:

I also added a commit to add color to the Interface icon (before the interface name).
image

This is not necessary and we can remove this commit if it is not desired.

@rdwebdesign rdwebdesign force-pushed the tweak/interfaces_alignment branch from 9717d87 to 1291f6f Compare January 27, 2025 21:03
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new alignment but not the new colored icons. To me it looks a bit strange: colored icon - non-colored name - colored status.

@rdwebdesign rdwebdesign force-pushed the tweak/interfaces_alignment branch from 1291f6f to e61df20 Compare January 29, 2025 22:19
@rdwebdesign
Copy link
Member Author

I removed the colored icons commit (force push) and added 2 commits to fix the alignment in LCARS theme.

@rdwebdesign rdwebdesign requested review from a team and yubiuser January 29, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants