Fix nixies not updating when seen through Remote View; add German loc…

…alization (#6) * Rename UPSFriendlyNixieTubeDisplay to UPSFriendlyNixieTubeDisplayFixed * Update info.json with bumped version number, new title/name/desc * Update changelog.txt * Fix nixies not updating when seen through remote view * Add German translation while I'm at it * Localization: Use Title Case for item names * Revert info.json changes (made for a fork) for merging back * Updated readme with credits and more unified formatting Formatting changes: - All bullet points uniformly end without a period - "Usage" section is now numbered, matching the mod portal des., as they are consecutive steps - Clarified that there are two technologies that can be researched - Unified single-quote symbols * Update README: Revert Mod Portal link to original mod, fix a line break in credits * Revert name change ("Fixed" suffix) --------- Co-authored-by: Hans van Luttikhuizen-Ross <[email protected]>
pindab0ter · Jan 28, 2025 · be66cda · be66cda
1 parent 4d417b7
commit be66cda
Show file tree

Hide file tree

Showing 5 changed files with 46 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 This is a fork of Santa's Nixie Tubes [mod](https://mods.factorio.com/mod/SantasNixieTubeDisplay) that has better performance and other improvements.
 
-Download the mod from the [Factorio Mods Portal](https://mods.factorio.com/mod/UPSFriendlyNixieTubeDisplay)
+Download the mod from the [Factorio Mod Portal](https://mods.factorio.com/mod/UPSFriendlyNixieTubeDisplay).
 
 ## Features
 
@@ -9,19 +9,19 @@ Download the mod from the [Factorio Mods Portal](https://mods.factorio.com/mod/U
 - Has a simple GUI to choose the signal
 - Performance improvements
   - It doesn't rerender numbers that haven't changed
-  - It doesn't use tanks as sprites for the numbers, so it will even show up nice on the mini map.
+  - It doesn't use tanks as sprites for the numbers, so it will even show up nice on the mini map
   - It doesn't use characters for colors, so no ups drops from lots of characters on the map
   - No colors (Nixies are orange from the heated filament)
 
 ## Usage
 
-- Research the technology
-- Place one or multiple Nixie Tubes in a row to display larger numbers
-- Connect a wire to the rightmost Nixie Tube in a row and choose a signal
+1) Research the respective technologies (Classic Nixie Tubes, Reinforced Nixie Tubes)
+2) Place one or multiple Nixie Tubes in a row to display larger numbers
+3) Connect a wire to the rightmost Nixie Tube in a row and choose a signal
 
 ## Changelog
 
-[changelog.txt](changelog.txt)
+Refer to [changelog.txt](changelog.txt)
 
 ## Contributing
 
@@ -34,17 +34,21 @@ This project is licensed under the MIT License.
 ## Credits
 
 [RedWizard](https://mods.factorio.com/user/RedWizard) for making an even more UPS friendly fork (this mod) of
-[lovely_santa](https://mods.factorio.com/user/lovely_santa)’s
+[lovely_santa](https://mods.factorio.com/user/lovely_santa)'s
 [fork](https://mods.factorio.com/mod/SantasNixieTubeDisplay) of
-[justarandomgeek](https://mods.factorio.com/user/justarandomgeek)’s
+[justarandomgeek](https://mods.factorio.com/user/justarandomgeek)'s
 [original mod](https://mods.factorio.com/mod/nixie-tubes).
 
 [pindab0ter](https://github.com/pindab0ter) for improving this mod and making it compatible with Factorio 2.0.
 
+[n00mkrad](https://github.com/n00mkrad) for Remote View fix and localization.
+
 ### Translations
 
 - Dutch
   - [pindab0ter](https://github.com/pindab0ter)
+- German
+  - [n00mkrad](https://github.com/n00mkrad)
 - Polish
   - [skill3472](https://github.com/skill3472)
 - Russian

diff --git a/changelog.txt b/changelog.txt
@@ -1,4 +1,9 @@
 ---------------------------------------------------------------------------------------------------
+Version: 0.2.9
+Date: 2025-01-27
+  Bugfixes:
+    - Fixed nixie tubes not updating when viewed through remote view [fork by nmkd]
+---------------------------------------------------------------------------------------------------
 Version: 0.2.8
 Date: 2024-12-09
   Translation:

diff --git a/info.json b/info.json
@@ -1,6 +1,6 @@
 {
   "name": "UPSFriendlyNixieTubeDisplay",
-  "version": "0.2.8",
+  "version": "0.2.9",
   "factorio_version": "2.0",
   "title": "UPS Friendly Nixie Tubes",
   "author": "Red_Wizard, pindab0ter",

diff --git a/locale/de/de.cfg b/locale/de/de.cfg
@@ -0,0 +1,27 @@
+[entity-name]
+nixie-tube=Nixie-Röhre
+classic-nixie-tube=Klassische Nixie-Röhre
+classic-nixie-tube-sprite=__ENTITY__classic-nixie-tube__
+reinforced-nixie-tube=Verstärkte Nixie-Röhre
+reinforced-nixie-tube-sprite=__ENTITY__reinforced-nixie-tube__
+small-reinforced-nixie-tube=Kleine Verstärkte Nixie-Röhre
+small-reinforced-nixie-tube-sprite=__ENTITY__small-reinforced-nixie-tube__
+
+[entity-description]
+classic-nixie-tube=Zeigt Signalwerte aus dem Schaltungsnetz an. Mehrere können nebeneinander platziert werden, um größere Zahlen darzustellen.
+reinforced-nixie-tube=Zeigt Signalwerte aus dem Schaltungsnetz an. Mehrere können nebeneinander platziert werden, um größere Zahlen darzustellen.
+small-reinforced-nixie-tube=Zeigt Signalwerte aus dem Schaltungsnetz an. Mehrere können nebeneinander platziert werden, um größere Zahlen darzustellen.
+
+[technology-name]
+classic-nixie-tubes=Klassische Nixie-Röhren
+reinforced-nixie-tubes=Verstärkte Nixie-Röhren
+
+[technology-description]
+classic-nixie-tubes=Klassische Nixie-Röhren zum anzeigen von Signalwerten aus dem Schaltungsnetz. Mehrere können nebeneinander platziert werden, um größere Zahlen darzustellen.
+reinforced-nixie-tubes=Verstärkte sowie Kleine Verstärkte Nixie-Röhren zum anzeigen von Signalwerten aus dem Schaltungsnetz. Mehrere können nebeneinander platziert werden, um größere Zahlen darzustellen.
+
+[mod-setting-name]
+nixie-tube-group-updates-per-tick=Nixie-Gruppen-Updates pro Tick
+
+[mod-setting-description]
+nixie-tube-group-updates-per-tick=Die maximale Anzahl an Nixie-Gruppen, die pro Tick aktualisiert werden. Eine höhere Zahl führt zu schnelleren Aktualisierungen, erhöht jedoch den Ressourcenverbrauch.
diff --git a/scripts/nixie_tube.lua b/scripts/nixie_tube.lua
@@ -394,7 +394,7 @@ local function on_tick(_)
     local eyes_on_surface = {}
     for i = 1, #game.connected_players do
         local player = game.connected_players[i]
-        if player.render_mode == defines.render_mode.game then
+        if player.render_mode == defines.render_mode.game or player.render_mode == defines.render_mode.chart_zoomed_in then
             eyes_on_surface[player.surface_index] = (eyes_on_surface[player.surface_index] or 0) + 1
         end
     end