Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM]Try kube tsdb dump #431

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[DNM]Try kube tsdb dump #431

wants to merge 6 commits into from
+416 −11

Conversation

nexustar
Copy link
Contributor

@nexustar nexustar commented Mar 6, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

srstack
srstack reviewed Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@srstack srstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srstack srstack added the not-merge No need to merge label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srstack srstack srstack left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
not-merge No need to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nexustar @srstack