Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM]add example for hardcode metrics list #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nexustar
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Patch coverage: 66.67% and project coverage change: -1.62 ⚠️

Comparison is base (c0cacb0) 30.11% compared to head (1fccce4) 28.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   30.11%   28.49%   -1.62%     
==========================================
  Files          50       50              
  Lines        4218     4212       -6     
==========================================
- Hits         1270     1200      -70     
- Misses       2778     2844      +66     
+ Partials      170      168       -2     
Flag Coverage Δ
unittests 28.49% <66.67%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/diag/command/root.go 20.29% <66.67%> (+0.57%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nexustar
Copy link
Contributor Author

example metrics are dumped from a tiup-playground deployed local cluster, may not precise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants