Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collector: add more retry when collect metrics #455

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

nexustar
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (88122e8) 30.19% compared to head (b08d351) 30.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   30.19%   30.19%           
=======================================
  Files          52       52           
  Lines        4362     4362           
=======================================
  Hits         1317     1317           
  Misses       2874     2874           
  Partials      171      171           
Flag Coverage Δ
unittests 30.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang merged commit d0d680a into pingcap:master Aug 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants