Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: add description about ticdc new architecture #19765

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Feb 10, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2025
@lidezhu lidezhu changed the title ticdc: add new description about ticdc new architecture ticdc: add description about ticdc new architecture Feb 10, 2025
@qiancai qiancai self-requested a review February 10, 2025 09:18
@qiancai qiancai added area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. v9.0 labels Feb 10, 2025
@qiancai qiancai self-assigned this Feb 10, 2025
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Feb 10, 2025
Copy link

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Feb 11, 2025

@lidezhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify 543d3b2 link true /test pull-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


TiCDC 新架构由两个主要部分组成,分别是 Log Service 和 Downstream Adapter,其中 Log Service 负责拉取上游集群的行变更和 DDL 信息并存储在本地,Downstream Adapter 则根据用户创建的 Changefeed 信息产生相关的同步任务从 Log Service 拉取相关数据并同步到下游。

### 核心组件
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议不要把内部的模块写在用户文档上,因为这些东西用户并不关心,并且后续还有可能会改。可以考虑换成新架构的设计特点,可以考虑从这几个点:

  1. 描述将系统划分为 Log Service 和 Downstream Adapter 的原因和带来的好处
  2. Timer Drivent 和 Event Drivent 模型,提升并发度、执行效率和扩展能力,同时可以处理海量的表
  3. 代码结构优化,降低复杂度

config:
newarch: true
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NOTE: 在使用 TiCDC 老架构时,请勿在配置文件中添加 `newarch` 配置项。`newarch` 仅用于新架构,不添加 `newarch` 配置项默认使用老架构。如果在 TiCDC 老架构的配置文件中添加 newarch,可能会导致解析失败。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

ti-chi-bot bot commented Feb 14, 2025

@wlwilliamx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot requested a review from flowbehappy February 14, 2025 08:35
Copy link
Contributor

@wlwilliamx wlwilliamx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

### `newarch`

- v9.0 版本引入,控制是否开启 TiCDC 新架构
- 默认值:`false`,表示不开启 TiCDC 新架构
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 默认值:`false`,表示不开启 TiCDC 新架构
- 设置为 `true`,表示开启 TiCDC 新架构
- 不添加 `newarch` 配置项默认使用老架构。`newarch` 仅用于新架构,如果在 TiCDC 老架构的配置文件中添加 newarch,可能会导致解析失败。

Copy link

ti-chi-bot bot commented Feb 14, 2025

@wlwilliamx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/CC @flowbehappy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. v9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants