support pipeline dml protocol in cdc #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <[email protected]>
YuJuncen
approved these changes
Apr 17, 2024
Signed-off-by: qupeng <[email protected]>
flowbehappy
approved these changes
Apr 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flowbehappy, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
New changes are detected. LGTM label has been removed. |
wuhuizuo
reviewed
Apr 17, 2024
Comment on lines
+78
to
+80
| // generation is for pipelined DML protocol. See kvrpcpb.FlushRequest.generation. | ||
| uint64 generation = 10; | ||
|
|
There was a problem hiding this comment.
should we put it after the 9th field?
There was a problem hiding this comment.
Not necessary. If other guys add more fileds with same id, proto compiler will report it. So we can always group fields by meanning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
generationfield tocdc.Event.Row.