FFI: add two empty implement FFI for compatibility #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinNeo
reviewed
Dec 22, 2023
| @@ -165,3 +165,18 @@ pub extern "C" fn ffi_handle_link_file( | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Lloyd-Pottiger
force-pushed
the
disagg-encryption-at-rest
branch
from
1d08c2a
to
7ff31ce
Compare
CalvinNeo
reviewed
Jan 17, 2024
| @@ -65,6 +65,8 @@ impl RaftStoreProxyFFIHelper { | |||
| fn_handle_new_file: Some(ffi_handle_new_file), | |||
| fn_handle_delete_file: Some(ffi_handle_delete_file), | |||
| fn_handle_link_file: Some(ffi_handle_link_file), | |||
| fn_get_keyspace_encryption: Some(CloudStorageEngineFFI::ffi_get_keyspace_encryption), | |||
There was a problem hiding this comment.
Could we also put these two ffis into one struct, like sst_reader_interfaces?
|
/retest |
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
|
/retest |
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note