Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closed]Adapt to TiKV's raft grpc message filter #416

Closed
wants to merge 13 commits into from

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jan 22, 2025

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

  • Introduce a TiFlashGrpcMessageFilter that will reject msgAppend and snapshot, once the memory reaches high water
  • Reduce log

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note


cfzjywxk and others added 12 commits January 13, 2025 10:13
close tikv#16818

Fix duplicated keys returned scanning locks.

Signed-off-by: cfzjywxk <[email protected]>
…ikv#18095)

close tikv#18117

Introduce a new field `use_one_pc` to the `Lock` struct to indicate whether the txn uses 1pc, and use it to prevent locks from being skipped when reading with max-ts.

Signed-off-by: zyguan <[email protected]>
…8099)

ref tikv#15990

* Increase task wait metrics upper limit from 2.5s to 42s to capture
  long task wait records that are crucial for investigating high
  latency issues
* Add description for end-point-memory-quota configuration

Signed-off-by: Neil Shen <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ref tikv#14474

Fix the request source check logic for external or internal

Signed-off-by: cfzjywxk <[email protected]>
close tikv#18125

Fix incorrect mapped allocation per thread metric

Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation.

Signed-off-by: Connor1996 <[email protected]>
close tikv#18111

Support scalar function from_unixtime in tikv

Signed-off-by: wshwsh12 <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
close tikv#18113

Support customized raft message rejection logic

Signed-off-by: Calvin Neo <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: glorv <[email protected]>
 

Signed-off-by: MyonKeminta <[email protected]>
Signed-off-by: ekexium <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>

Co-authored-by: MyonKeminta <[email protected]>
Co-authored-by: ekexium <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
Copy link

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from calvinneo, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 7 committers have signed the CLA.

✅ wshwsh12
✅ CalvinNeo
❌ cfzjywxk
❌ LykxSassinator
❌ zyguan
❌ overvenus
❌ Connor1996
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 22, 2025
@CalvinNeo CalvinNeo changed the title U mem 2 Adapt to TiKV's raft grpc message filter Jan 22, 2025
Signed-off-by: Calvin Neo <[email protected]>
@CalvinNeo CalvinNeo added the tide/merge-method-merge merge method merge label Jan 22, 2025
@CalvinNeo CalvinNeo changed the title Adapt to TiKV's raft grpc message filter [Closed]Adapt to TiKV's raft grpc message filter Jan 22, 2025
@CalvinNeo CalvinNeo closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants