Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-server: add deleteTidbCluster api #5371

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

z2665
Copy link
Contributor

@z2665 z2665 commented Nov 4, 2023

What problem does this PR solve?

add delete TidbCluster api for http-server

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code
  1. use CreateCluster http api to create a tidb cluster
    see example/create-cluster.json

  2. check tidb running success
    image

  3. call DeleteCluster http api to delete the tidb cluster

{
  "success": true
}

image
check namespace,secret,tidbmonitor and tidbInitializers all be deleted

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tennix for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 November 4, 2023 14:27
@sre-bot
Copy link
Contributor

sre-bot commented Nov 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

ti-chi-bot bot commented Nov 4, 2023

Welcome @z2665! It looks like this is your first PR to pingcap/tidb-operator 🎉

@ti-chi-bot ti-chi-bot bot added the size/XXL label Nov 4, 2023
@z2665 z2665 force-pushed the feature/http_delete_cluster branch from 917e645 to cc04ee7 Compare November 4, 2023 16:53
@z2665 z2665 force-pushed the feature/http_delete_cluster branch from 34387f4 to bf432c8 Compare November 4, 2023 17:01
@codecov-commenter
Copy link

Codecov Report

Merging #5371 (d9b4c69) into master (0cd81d1) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5371   +/-   ##
=======================================
  Coverage   61.59%   61.60%           
=======================================
  Files         228      228           
  Lines       28866    28866           
=======================================
+ Hits        17780    17782    +2     
+ Misses       9342     9341    -1     
+ Partials     1744     1743    -1     
Flag Coverage Δ
unittest 61.60% <ø> (+<0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit 0b10432 into pingcap:master Nov 6, 2023
4 checks passed
@z2665 z2665 deleted the feature/http_delete_cluster branch November 6, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants