Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete all pvc in tidbcluster ns #5373

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

z2665
Copy link
Contributor

@z2665 z2665 commented Nov 6, 2023

What problem does this PR solve?

delete all PVCs when call delete TidbCluster api

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 6, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-06 08:01:33.70679772 +0000 UTC m=+3458491.293907852: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Nov 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5373 (a64c21c) into master (0b10432) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5373   +/-   ##
=======================================
  Coverage   61.59%   61.60%           
=======================================
  Files         228      228           
  Lines       28866    28866           
=======================================
+ Hits        17781    17782    +1     
  Misses       9341     9341           
+ Partials     1744     1743    -1     
Flag Coverage Δ
unittest 61.60% <ø> (+<0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit b7170fa into pingcap:master Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants