Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: add some app.kubernetes.io/* labels back #6047

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot added the size/L label Jan 17, 2025
@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-v2

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (65c3a1d) to head (f92a4b3).

Additional details and impacted files
@@              Coverage Diff               @@
##           feature/v2    #6047      +/-   ##
==============================================
+ Coverage       69.94%   69.97%   +0.02%     
==============================================
  Files             154      153       -1     
  Lines            9517     9524       +7     
==============================================
+ Hits             6657     6664       +7     
  Misses           2860     2860              
Flag Coverage Δ
unittest 69.97% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

@fgksgf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fgksgf
Once this PR has been reviewed and has the lgtm label, please ask for approval from csuzhangxc, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc enabled auto-merge (squash) January 17, 2025 06:42
@csuzhangxc csuzhangxc merged commit 47d6ecc into pingcap:feature/v2 Jan 17, 2025
7 of 8 checks passed
@csuzhangxc csuzhangxc deleted the k8s-labels branch January 17, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants