Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crd): add missing listType #6108

Open
wants to merge 1 commit into
base: feature/v2
Choose a base branch
from
Open

feat(crd): add missing listType #6108

wants to merge 1 commit into from

Conversation

liubog2008
Copy link
Member

  • add missing listType for arrays

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from liubog2008, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot added the v2 for operator v2 label Mar 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

/run-pull-e2e-kind-v2

@ti-chi-bot ti-chi-bot bot added the size/XXL label Mar 6, 2025
csuzhangxc
csuzhangxc reviewed Mar 6, 2025
View reviewed changes
api/core/v1alpha1/common_types.go
Comment on lines +162 to +163
// +listType=map
// +listMapKey=name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why empty line here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

Assignees
No one assigned
Labels
size/XXL v2 for operator v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liubog2008 @csuzhangxc