Support vector index for SQLAlchemy #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
wd0517
reviewed
Nov 5, 2024
| f"vec_idx_{column.name}" | ||
| ) | ||
|
|
||
| query = sqlalchemy.text(f"ALTER TABLE {table_name} SET TIFLASH REPLICA 1") |
There was a problem hiding this comment.
I think we should setting a TiFlash replica only if it doesn't already exist, or what if this table already have a tilfash replica with 2?
There was a problem hiding this comment.
Maybe this use case priority could be lowered, as I'm considering this:
If the user has already jump to SQL to manipulate the table, out of this driver's control, then maybe he don't need this driver's help to add a new index?
There was a problem hiding this comment.
Users may exhibit various behaviors, such as manually setting Tiflash replicas via SQLAlchemy's sql.execute when using this adapter. We should effectively handle these scenarios.
There was a problem hiding this comment.
Ok, good point. I will change this.
Co-authored-by: WD <[email protected]>
Signed-off-by: Wish <[email protected]>
Signed-off-by: Wish <[email protected]>
wd0517
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #63
After discussion with @JaySon-Huang, inspired by some other vector databases, I think we could simply introduce some side functions for creating indexes. The usage is as simple as using native SQLAlchemy interfaces, without the need to introduce another dialect like sqlalchemy-tidb.
Maintaining a new SQLAlchemy dialect is costy, as we need to support both SQLAlchemy 1.4 and SQLAlchemy 2.0, and support other TiDB features like AUTO_RANDOM.