examples: use new vector index syntax #70
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -57,7 +57,6 @@ class Cache(SQLModel, table=True): | |||
| sa_column=Column( | |||
| VectorType(768), | |||
| default=None, | |||
There was a problem hiding this comment.
also using create_vector_index instead?
There was a problem hiding this comment.
Vector index syntax is strange, I suggest only show it in orm examples. Core team will introduce new vector index creating syntax later.
There was a problem hiding this comment.
I guess there might be no high-priority plan of introducing a new syntax in recent versions, because ORM users are already using a good encapsulated one. Even after a new syntax is introduced I don't think we could avoid using Adaptor in all ORMs, because of the syntax prefix like ADD VECTOR INDEX. For this reason I guess the new syntax is mainly for ORM adaptors to have a simple implementation (while taking care of TiFlash multi replicas). How users use the ORM might not change, or at least it is not the goal.
There was a problem hiding this comment.
This PR introduced a new VectorIndex which can replace current VectorAdapter.
No description provided.