Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Switch on the pushdown for first_value() and last_value #44157

Merged
merged 5 commits into from
Jun 7, 2023
Merged

expression: Switch on the pushdown for first_value() and last_value #44157

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
313d74f
init
xzhangxian1008 May 25, 2023
ec59e05
Merge branch 'master' of github.com:pingcap/tidb into first_last_push…
xzhangxian1008 May 30, 2023
8c2eaff
1
xzhangxian1008 May 30, 2023
5a1293b
1
xzhangxian1008 Jun 1, 2023
4c354d6
1
xzhangxian1008 Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion expression/aggregation/window_func.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ func (s *WindowFuncDesc) CanPushDownToTiFlash(ctx sessionctx.Context) bool {
}
// window functions
switch s.Name {
case ast.WindowFuncRowNumber, ast.WindowFuncRank, ast.WindowFuncDenseRank, ast.WindowFuncLead, ast.WindowFuncLag:
case ast.WindowFuncRowNumber, ast.WindowFuncRank, ast.WindowFuncDenseRank, ast.WindowFuncLead, ast.WindowFuncLag,
xzhangxian1008 marked this conversation as resolved.
Show resolved Hide resolved
ast.WindowFuncFirstValue, ast.WindowFuncLastValue:
return true
// TODO: support aggregate functions
//case ast.AggFuncSum, ast.AggFuncCount, ast.AggFuncAvg, ast.AggFuncMax, ast.AggFuncMin:
Expand Down
22 changes: 12 additions & 10 deletions planner/core/exhaust_physical_plans.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2765,16 +2765,18 @@ func (lw *LogicalWindow) tryToGetMppWindows(prop *property.PhysicalProperty) []P
return nil
}
if lw.Frame != nil && lw.Frame.Type == ast.Ranges {
if _, err := expression.ExpressionsToPBList(lw.SCtx().GetSessionVars().StmtCtx, lw.Frame.Start.CalcFuncs, lw.ctx.GetClient()); err != nil {
lw.SCtx().GetSessionVars().RaiseWarningWhenMPPEnforced(
"MPP mode may be blocked because window function frame can't be pushed down, because " + err.Error())
return nil
}
if _, err := expression.ExpressionsToPBList(lw.SCtx().GetSessionVars().StmtCtx, lw.Frame.End.CalcFuncs, lw.ctx.GetClient()); err != nil {
lw.SCtx().GetSessionVars().RaiseWarningWhenMPPEnforced(
"MPP mode may be blocked because window function frame can't be pushed down, because " + err.Error())
return nil
}
// TODO uncomment these codes after tiflash support range frame type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment these codes? I think we should keep the warnings if it can't be pushed to TiFlash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment these codes? I think we should keep the warnings if it can't be pushed to TiFlash

okk, i will uncomment them

// if _, err := expression.ExpressionsToPBList(lw.SCtx().GetSessionVars().StmtCtx, lw.Frame.Start.CalcFuncs, lw.ctx.GetClient()); err != nil {
// lw.SCtx().GetSessionVars().RaiseWarningWhenMPPEnforced(
// "MPP mode may be blocked because window function frame can't be pushed down, because " + err.Error())
// return nil
// }
// if _, err := expression.ExpressionsToPBList(lw.SCtx().GetSessionVars().StmtCtx, lw.Frame.End.CalcFuncs, lw.ctx.GetClient()); err != nil {
// lw.SCtx().GetSessionVars().RaiseWarningWhenMPPEnforced(
// "MPP mode may be blocked because window function frame can't be pushed down, because " + err.Error())
// return nil
// }
return nil
xzhangxian1008 marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down