Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: advacned prepare implementation (#48439) #50520

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #48439

What problem does this PR solve?

Issue Number: close #50359

Problem Summary:
This PR implemented the client side of the enhanced prepare stage of snapshot backup.

What is changed and how it works?

Generally this is a state machine that tries to collect the whole range. If a region has applied to the last index, the region's range will be collected. When the whole key space has been collected, we are done.

Check List

Tests

  • Unit test (TBD)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jan 17, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 17, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 17, 2024
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@021a4e3). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #50520   +/-   ##
================================================
  Coverage               ?   73.6406%           
================================================
  Files                  ?       1094           
  Lines                  ?     350487           
  Branches               ?          0           
================================================
  Hits                   ?     258101           
  Misses                 ?      75814           
  Partials               ?      16572           

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 18, 2024
Copy link

ti-chi-bot bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 18, 2024
Copy link

ti-chi-bot bot commented Jan 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-17 13:31:34.493234226 +0000 UTC m=+362736.057531930: ☑️ agreed by BornChanger.
  • 2024-01-18 02:48:03.990553377 +0000 UTC m=+410525.554851251: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit e850d08 into pingcap:release-6.5 Jan 18, 2024
19 checks passed
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants