Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix reorg handle not resumed after changing DDL owner #56507

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Oct 9, 2024

What problem does this PR solve?

Issue Number: close #56506

Problem Summary:

  1. doneTaskKeeper starts from 0, but taskIDAllocator starts from 1.
  2. "not owner" error is eaten by context.Canceled.

What changed and how does it work?

Allocate task ID from 0.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2024
Copy link

tiprow bot commented Oct 9, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta tangenta changed the title ddl: fix handle will not be resumed during reorg ddl: fix reorg handle not resumed after changing DDL owner Oct 9, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1233%. Comparing base (ff1b241) to head (564b1ed).
Report is 749 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56507        +/-   ##
================================================
+ Coverage   73.3181%   76.1233%   +2.8051%     
================================================
  Files          1625       1649        +24     
  Lines        448639     465471     +16832     
================================================
+ Hits         328934     354332     +25398     
+ Misses        99547      89264     -10283     
- Partials      20158      21875      +1717     
Flag Coverage Δ
integration 51.8330% <92.3076%> (?)
unit 72.4549% <100.0000%> (+0.0082%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 61.4738% <ø> (+15.9281%) ⬆️

pkg/ddl/backfilling.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
Copy link

ti-chi-bot bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 11, 2024
Copy link

ti-chi-bot bot commented Oct 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-09 08:19:27.705473283 +0000 UTC m=+1034123.125686287: ☑️ agreed by D3Hunter.
  • 2024-10-11 01:47:03.255840293 +0000 UTC m=+1183378.676053300: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 3c4b230 into pingcap:master Oct 11, 2024
25 checks passed
@tangenta tangenta added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Oct 11, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56571.

@tangenta tangenta added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 31, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 31, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57021.

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 12, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 3, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57926.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 21, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 21, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #59065.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reorg handle not resumed after changing DDL owner
4 participants