planner: Use realtimeRowCount when all topN collected

[terry1purcell]

What problem does this PR solve?

Issue Number: close #47400

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 56.6761%. Comparing base (241c102) to head (a6102b2).
Report is 554 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #56848         +/-   ##
=================================================
- Coverage   73.2075%   56.6761%   -16.5315%     
=================================================
  Files          1652       1786        +134     
  Lines        456143     648543     +192400     
=================================================
+ Hits         333931     367569      +33638     
- Misses       101688     256382     +154694     
- Partials      20524      24592       +4068     

Flag	Coverage Δ
integration	37.0445% <36.3636%> (?)
unit	72.4607% <54.5454%> (-0.0234%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	55.2602% <ø> (+2.3124%)	⬆️
parser	∅ <ø> (∅)
br	52.9576% <ø> (+6.9697%)	⬆️

[qw4990]

Can we add the case in #47400 as a UT here?

[qw4990]

LGTM, but it's my first time to see using "Sqrt" in cardinality estimation, is there any source of this formula, or any intuition/insight behind this formula? @terry1purcell

[purelind]

/retest

[tiprow]

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[qw4990]

/ok-to-test

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-01 14:07:30.285347454 +0000 UTC m=+617963.124503003: ☑️ agreed by qw4990.
• 2024-11-04 12:48:14.311541197 +0000 UTC m=+872407.150696740: ☑️ agreed by winoros.

[winoros]

/hold for a possible test case

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990, Rustin170506, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/planner/OWNERS [Rustin170506,hawkingrei,qw4990,winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Rustin170506]

/unhold

[terry1purcell]

/retest

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #57224.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #57689.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #58151.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #58174.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #59075.