-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick-7.5: br: restore checksum shouldn't rely on backup checksum (#56712) #58225
cherry-pick-7.5: br: restore checksum shouldn't rely on backup checksum (#56712) #58225
Conversation
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1f297a0
to
e2d8c6b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #58225 +/- ##
================================================
Coverage ? 72.5035%
================================================
Files ? 1417
Lines ? 416101
Branches ? 0
================================================
Hits ? 301688
Misses ? 94496
Partials ? 19917
Flags with carried forward coverage won't be shown. Click here to find out more.
|
close pingcap#56373 (cherry picked from commit 4f047be)
e2d8c6b
to
3d4d3f3
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
close #56373
(cherry picked from commit 4f047be)
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
The default behavior of doing checksum during full backup has changed from enabled to disabled.
The meaning of checksum flag is kind of ambiguous here, it doesn't mean we don't do the checksum of files when doing backup, instead we don't do checksum to compare from coprocessor side to the br side to improve the performance
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.