table: Don't cast date default values (same as timestamp/datetime) | tidb-test=pr/2472

[mjonss]

What problem does this PR solve?

Issue Number: close #59047

Problem Summary:
During the executor build phase getColDefaultValue is called for the date column and fails, due to trying to cast the default value '0000-00-00' which fails due to default sql_mode.

The underlying issue seems to be that CREATE TABLE does not set column.OriginDefaultValue, while ALTER TABLE ADD COLUMN does, which is ignored in this PR.

What changed and how does it work?

Do as DATETIME and TIMESTAMP, skip cast.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix UPDATE after ALTER ADD date column giving error for incorrect value '0000-00-00'.

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[YangKeao]

/check-issue-triage-complete

[YangKeao]

I've updated the mysql-test result in https://github.com/PingCAP-QE/tidb-test/pull/2472.

[YangKeao]

/retest

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@49d7761). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-6.5     #59049   +/-   ##
================================================
  Coverage               ?   73.6212%           
================================================
  Files                  ?       1097           
  Lines                  ?     353049           
  Branches               ?          0           
================================================
  Hits                   ?     259919           
  Misses                 ?      76398           
  Partials               ?      16732           

[ti-chi-bot]

@mjonss: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-br-integration-test	c91b177	link	false	/test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dveeden]

/check-issue-triage-complete

[YangKeao]

LGTM

[hawkingrei]

/check-issue-triage-complete

[purelind]

/check-issue-triage-complete

[purelind]

/retest

[tiprow]

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wuhuizuo]

/run-check-issue-triage-complete

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [YangKeao,dveeden]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-01-21 06:45:37.462360775 +0000 UTC m=+163264.793280179: ☑️ agreed by YangKeao.
• 2025-01-21 07:13:39.16620622 +0000 UTC m=+164946.497125624: ☑️ agreed by dveeden.