ddl notifier: use pagination for SELECT to reduce memory usage (#58376) (#58488)

[ti-chi-bot]

This is an automated cherry-pick of #58488

This is an automated cherry-pick of #58376

What problem does this PR solve?

Issue Number: close #58368
close #58869

Problem Summary:

What changed and how does it work?

as title. refine the Store.List.

// Store is the (de)serialization and persistent layer.
type Store interface {
...
	// List will start a transaction of given session and read all schema changes
	// through a ListResult. The ownership of session is occupied Store until CloseFn
	// is called.
	List(ctx context.Context, se *sess.Session) ListResult
}

// ListResult is the result stream of a List operation.
type ListResult interface {
	// Read tries to decode at most `len(changes)` SchemaChange into given slices. It
	// returns the number of schemaChanges decoded, 0 means no more schemaChanges.
	//
	// Note that the previous SchemaChange in the slice will be overwritten when call
	// Read.
	Read(changes []*SchemaChange) (int, error)
}

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[Rustin170506]

Thanks!

[codecov]

Codecov Report

Attention: Patch coverage is 85.95041% with 17 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5-20250114-v8.5.0@04a27be). Learn more about missing BASE report.

Additional details and impacted files

@@                       Coverage Diff                        @@
##             release-8.5-20250114-v8.5.0     #59217   +/-   ##
================================================================
  Coverage                               ?   57.3685%           
================================================================
  Files                                  ?       1778           
  Lines                                  ?     630753           
  Branches                               ?          0           
================================================================
  Hits                                   ?     361854           
  Misses                                 ?     243898           
  Partials                               ?      25001           

Flag	Coverage Δ
integration	37.6579% <72.7272%> (?)
unit	72.4323% <85.9504%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.8711% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	55.5948% <0.0000%> (?)

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-01-27 06:27:31.319549142 +0000 UTC m=+680578.650468546: ☑️ agreed by Rustin170506.
• 2025-01-27 06:58:35.004618182 +0000 UTC m=+682442.335537601: ☑️ agreed by lance6716.

[Rustin170506]

/retest

[lance6716]

/retest

[ti-chi-bot]

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/mysql-test	cf7c3a0	link	true	/test mysql-test
pull-br-integration-test	cf7c3a0	link	true	/test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.