Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: mem dump when about to OOM #59234

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Jan 31, 2025

What problem does this PR solve?

Issue Number: close #56971

Problem Summary:

What changed and how does it work?

Added a memory monitor that dumps the heap dump before it's about to OOM (reach 90% of mem), logs memory usage warning when reaching 80%.
Keeps only max 3 heap dumps so not spamming the disk
Generate only at 5 mins interval if needed
Output dir is configured though env and it should be persistent, default is /tmp/heapdump

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Wenqi Mou <[email protected]>
Copy link

ti-chi-bot bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 31, 2025
Copy link

tiprow bot commented Jan 31, 2025

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Wenqi Mou <[email protected]>
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 48.29932% with 76 lines in your changes missing coverage. Please review.

Project coverage is 74.6834%. Comparing base (43f2fb9) to head (e66a0c0).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59234        +/-   ##
================================================
+ Coverage   73.0563%   74.6834%   +1.6270%     
================================================
  Files          1689       1706        +17     
  Lines        467012     467248       +236     
================================================
+ Hits         341182     348957      +7775     
+ Misses       104853      96549      -8304     
- Partials      20977      21742       +765     
Flag Coverage Δ
integration 46.0037% <42.8571%> (?)
unit 72.2705% <23.1292%> (+0.0351%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.0620% <48.2993%> (+15.6017%) ⬆️

Signed-off-by: Wenqi Mou <[email protected]>
Signed-off-by: Wenqi Mou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BR: create a heap dump to a persistent storage when BR is about to OOM
1 participant