Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add circuit breaker metrics #59338

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 8, 2025

What problem does this PR solve?

Issue Number: ref #58780

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
Screenshot 2025-02-08 at 12 09 34

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2025
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8034%. Comparing base (397b0f2) to head (f60ba0a).
Report is 35 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59338        +/-   ##
================================================
+ Coverage   73.0599%   73.8034%   +0.7435%     
================================================
  Files          1690       1697         +7     
  Lines        467367     476696      +9329     
================================================
+ Hits         341458     351818     +10360     
+ Misses       104902     103938       -964     
+ Partials      21007      20940        -67     
Flag Coverage Δ
integration 43.5320% <ø> (?)
unit 72.8546% <ø> (+0.6179%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 43.8978% <ø> (-1.8881%) ⬇️

@rleungx rleungx force-pushed the circuit-breaker-metrics branch from 731bb97 to 49541dc Compare February 14, 2025 06:53
@rleungx
Copy link
Member Author

rleungx commented Feb 14, 2025

/cc @nolouch @lcwangchao @Tema

@ti-chi-bot ti-chi-bot bot requested review from nolouch and lcwangchao February 14, 2025 06:54
Copy link

ti-chi-bot bot commented Feb 14, 2025

@rleungx: GitHub didn't allow me to request PR reviews from the following users: Tema.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @nolouch @lcwangchao @Tema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rleungx
Copy link
Member Author

rleungx commented Feb 14, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 14, 2025
Signed-off-by: Ryan Leung <[email protected]>
Copy link

ti-chi-bot bot commented Feb 15, 2025

@Tema: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, tangenta, Tema

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 18, 2025
Copy link

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-14 07:01:59.211572666 +0000 UTC m=+599161.607794727: ☑️ agreed by nolouch.
  • 2025-02-18 06:34:55.398260978 +0000 UTC m=+943137.794483040: ☑️ agreed by tangenta.

@rleungx
Copy link
Member Author

rleungx commented Feb 18, 2025

/retest

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Feb 18, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1ce8c21 into pingcap:master Feb 18, 2025
24 checks passed
@rleungx rleungx deleted the circuit-breaker-metrics branch February 18, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants