refine

Signed-off-by: guo-shaoge <[email protected]>
pingcap · Jan 7, 2025 · 3878b4b · 3878b4b
1 parent 19982d3
commit 3878b4b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/dbms/src/Columns/ColumnString.cpp b/dbms/src/Columns/ColumnString.cpp
@@ -958,7 +958,6 @@ void ColumnString::deserializeAndInsertFromPosImpl(
         memcpySmallAllowReadWriteOverflow15(&chars[char_size], pos[i], str_size);
         char_size += str_size;
 
-        // todo add unit test
         if constexpr (add_terminating_zero)
         {
             chars[char_size] = 0;
@@ -1018,7 +1017,6 @@ void ColumnString::deserializeAndInsertFromPosForColumnArrayImpl(
     {
         for (size_t i = 0; i < size; ++i)
         {
-            // TODO add unit test
             for (size_t j = array_offsets[start_point + i - 1]; j < array_offsets[start_point + i]; ++j)
             {
                 UInt32 str_size;

diff --git a/dbms/src/Columns/IColumn.h b/dbms/src/Columns/IColumn.h
@@ -311,7 +311,7 @@ class IColumn : public COWPtr<IColumn>
     ///     while (xxx)
     ///     {
     ///         for (auto & column_ptr : mutable_columns)
-    ///             column_ptr->deserializeAndInsertFromPosUnique(pos, align_buffer, true);
+    ///             column_ptr->deserializeAndInsertFromPos(pos, align_buffer, true);
     ///     }
     ///     for (auto & column_ptr : mutable_columns)
     ///         column_ptr->flushNTAlignBuffer();