-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdms(playground, cluster): add name to start pdms #2438
Conversation
Signed-off-by: husharp <[email protected]>
bb5f092
to
2ebaaeb
Compare
d5d63a2
to
fa0e6f0
Compare
Signed-off-by: husharp <[email protected]>
fa0e6f0
to
938fd7f
Compare
PTAL, thx! @kaaaaaaang @rleungx |
Signed-off-by: husharp <[email protected]>
@kaaaaaaang @rleungx friendly ping :) |
@xhebox can you take a look at this pr? thx~ :) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@HuSharp: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2438 +/- ##
==========================================
- Coverage 50.23% 48.72% -1.51%
==========================================
Files 333 333
Lines 35896 35966 +70
==========================================
- Hits 18032 17524 -508
- Misses 15503 16143 +640
+ Partials 2361 2299 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
[LGTM Timeline notifier]Timeline:
|
This reverts commit 9c5ad9a.
What problem does this PR solve?
Ref #8157
What is changed and how it works?
after tikv/pd#8157, we can start PDms with name.
But startup previous pd which support ms before 8.3.0 will failure because of
unkown flag
for 8.2.0
after
./tiup-cluster upgrade tidb-test v8.2.0 --tso-version v8.3.0
and withtso_servers: - host: 10.2.7.79 port: 3379 name: "tso-0"
we can cat
tidb-deploy/tso-3379/scripts
We need to keep compatible by changing pdms script
Check List
Tests
Release notes: