cluster: improved error for missing tar #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XS
breezewish
reviewed
Jan 21, 2025
| @@ -51,6 +52,9 @@ func (c *InstallPackage) Execute(ctx context.Context) error { | |||
|
|
|||
| _, stderr, err := exec.Execute(ctx, cmd, false) | |||
| if err != nil { | |||
| if bytes.Contains(stderr, []byte("command not found")) { | |||
There was a problem hiding this comment.
How about polish the text to install tar in the host xxx (xxx is the dest host name)? Then user will not misunderstood to install in the current machine. The rest LGTM.
There was a problem hiding this comment.
Fixed in 16da107
$ tiup cluster check topology.yaml
The SSH identity key is encrypted. Input its passphrase:
+ Detect CPU Arch Name
- Detecting node 192.168.122.196 Arch info ... Done
+ Detect CPU OS Name
- Detecting node 192.168.122.196 OS info ... Done
+ Download necessary tools
- Downloading check tools for linux/amd64 ... Done
+ Collect basic system information
- Getting system info of 192.168.122.196:22 ... Error
Error: tar command was not found on 192.168.122.196, please install it
Verbose debug logs has been written to /home/dvaneeden/.tiup/logs/tiup-cluster-debug-2025-01-21-13-26-46.log.
breezewish
approved these changes
Jan 21, 2025
[LGTM Timeline notifier]Timeline:
|
|
/cc @xhebox |
xhebox
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
With a minimal install of Rocky Linux 9.5 tar isn't installed and the error could be improved
Without this PR:
With this PR:
What is changed and how it works?
Check List
Tests
Release notes: