Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the bazel examples #25

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore: fix the bazel examples #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,18 @@ jobs:
run: mvn install -DskipTests
- name: Maven test
run: mvn test
- name: Run Gradle exammple
- name: Run Gradle example
run: ./gradlew build run --no-daemon
working-directory: examples/gradle
- name: Run Gradle ICU exammple
- name: Run Gradle ICU example
run: ./gradlew build run --no-daemon
working-directory: examples/gradle-icu
- if: ${{ matrix.bazel }}
name: Run Bazel exammple
name: Run Bazel example
run: bazel build //:l10nbazel; bazel-bin/l10nbazel
working-directory: examples/bazel-local
- if: ${{ matrix.bazel }}
name: Run Bazel ICU exammple
name: Run Bazel ICU example
run: bazel build //:l10nbazel; bazel-bin/l10nbazel
working-directory: examples/bazel-icu-local

Expand Down
2 changes: 1 addition & 1 deletion examples/bazel-icu/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ maven_install(
artifacts = [
"com.ibm.icu:icu4j:72.1",
"com.pinterest.l10nmessages:l10nmessages:1.0.4",
"com.pinterest.l10nmessages:l10nmessages_proc:1.0.4"
"com.pinterest.l10nmessages:l10nmessages-proc:1.0.4"
],
repositories = [
"https://repo1.maven.org/maven2",
Expand Down
2 changes: 0 additions & 2 deletions examples/bazel-local/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
RULES_JVM_EXTERNAL_TAG = "4.2"
RULES_JVM_EXTERNAL_SHA = "cd1a77b7b02e8e008439ca76fd34f5b07aecb8c752961f9640dea15e9e5ba1ca"

# local repository to use the jar file from parent project
# local repository to use the jar file from parent project
# local repository to use the jar file from parent project
new_local_repository(
name = "l10nmessages_local",
Expand Down
2 changes: 1 addition & 1 deletion examples/bazel/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ load("@rules_jvm_external//:defs.bzl", "maven_install")
maven_install(
artifacts = [
"com.pinterest.l10nmessages:l10nmessages:1.0.4",
"com.pinterest.l10nmessages:l10nmessages_proc:1.0.4"
"com.pinterest.l10nmessages:l10nmessages-proc:1.0.4"
],
repositories = [
"https://repo1.maven.org/maven2",
Expand Down
2 changes: 1 addition & 1 deletion update-non-maven-versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ then
# Bazel examples
echo "Updating to release"
sed -E -i '' -e "s/l10nmessages:${CURRENT_VERSION}/l10nmessages:${NEW_VERSION}/g" examples/{bazel,bazel-icu}/WORKSPACE;
sed -E -i '' -e "s/l10nmessages_proc:${CURRENT_VERSION}/l10nmessages_proc:${NEW_VERSION}/g" examples/{bazel,bazel-icu}/WORKSPACE;
sed -E -i '' -e "s/l10nmessages-proc:${CURRENT_VERSION}/l10nmessages-proc:${NEW_VERSION}/g" examples/{bazel,bazel-icu}/WORKSPACE;

# Docs
sed -E -i '' -e "s/l10nmessages:${CURRENT_VERSION}/l10nmessages:${NEW_VERSION}/g" docs/docs/installation/{bazel,gradle}.md;
Expand Down