Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18N-1308: Add environment name to PagerDuty incident #229

Merged

Conversation

byronantak
Copy link
Collaborator

Include more detail in incident to make it more useful for the future

@byronantak byronantak requested a review from a team as a code owner January 24, 2025 11:15
@byronantak byronantak force-pushed the log/add-mojito-environment-name-to-pager-duty-incident branch from 9e32c5b to 2803c60 Compare January 24, 2025 11:16
@byronantak byronantak self-assigned this Jan 24, 2025
@byronantak byronantak force-pushed the log/add-mojito-environment-name-to-pager-duty-incident branch from ead15f3 to 2803c60 Compare January 24, 2025 15:10
@byronantak byronantak enabled auto-merge (squash) January 24, 2025 15:36
Copy link
Member

@mattwilshire mattwilshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you Autowire the ServerConfig here instead of the Environment ? The ServerConfig has a getUrl method that retrieves this environment variable you are accessing here: serverConfig.getUrl()

@byronantak byronantak force-pushed the log/add-mojito-environment-name-to-pager-duty-incident branch from 6f030b3 to 4287a42 Compare February 6, 2025 13:25
@mattwilshire mattwilshire self-requested a review February 6, 2025 13:28
@byronantak byronantak merged commit faa29fc into master Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants