Skip to content

Commit

Permalink
remove TODO, Finished is not encrypted yet
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Mangum <[email protected]>
  • Loading branch information
hasheddan committed Jul 18, 2023
1 parent 51bba14 commit 8b8ce87
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ func (c *Conn) writePackets(ctx context.Context, pkts []*packet) error {
c.log.Tracef("[handshake:%v] -> %s (epoch: %d, seq: %d)",
srvCliStr(c.state.isClient), h.Header.Type.String(),
p.record.Header.Epoch, h.Header.MessageSequence)
// TODO: Finished record may contain CID.

c.handshakeCache.push(handshakeRaw[recordlayer.DefaultHeaderSize:], p.record.Header.Epoch, h.Header.MessageSequence, h.Header.Type, c.state.isClient)

rawHandshakePackets, err := c.processHandshakePacket(p, h)
Expand Down Expand Up @@ -558,7 +558,7 @@ func (c *Conn) processHandshakePacket(p *packet, h *handshake.Handshake) ([][]by
RealType: protocol.ContentTypeHandshake,
Zeros: 8,
}
rawInner, err := inner.Marshal()
rawInner, err := inner.Marshal() //nolint:govet
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -807,7 +807,7 @@ func (c *Conn) handleIncomingPacket(ctx context.Context, buf []byte, rAddr net.A
// further processing.
if h.ContentType == protocol.ContentTypeConnectionID {
ip := &recordlayer.InnerPlaintext{}
if err := ip.Unmarshal(buf[h.Size():]); err != nil {
if err := ip.Unmarshal(buf[h.Size():]); err != nil { //nolint:govet
c.log.Debugf("unpacking inner plaintext failed: %s", err)
return false, nil, nil
}
Expand Down

0 comments on commit 8b8ce87

Please sign in to comment.