Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interceptor to aggregate CCFB reports #300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Add fallback for missing TWCC header extension

1072695
Select commit
Loading
Failed to load commit list.
Open

Add interceptor to aggregate CCFB reports #300

Add fallback for missing TWCC header extension
1072695
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2025 in 1s

72.26% (+0.87%) compared to c06f448

View this Pull Request on Codecov

72.26% (+0.87%) compared to c06f448

Details

Codecov Report

Attention: Patch coverage is 83.75000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (c06f448) to head (1072695).

Files with missing lines Patch % Lines
pkg/ccfb/interceptor.go 77.44% 22 Missing and 8 partials ⚠️
pkg/ccfb/twcc_receiver.go 70.83% 21 Missing ⚠️
internal/test/mock_stream.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   71.38%   72.26%   +0.87%     
==========================================
  Files          79       84       +5     
  Lines        4526     4842     +316     
==========================================
+ Hits         3231     3499     +268     
- Misses       1158     1199      +41     
- Partials      137      144       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.