WIP: simplify interface to TWCC 4/4 #3003
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3003 +/- ##
===========================================
- Coverage 77.77% 63.68% -14.10%
===========================================
Files 89 67 -22
Lines 10578 3957 -6621
===========================================
- Hits 8227 2520 -5707
+ Misses 1857 1308 -549
+ Partials 494 129 -365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jech
changed the title
Make it possible to add interceptors at NewPeerConnection time.
Simplify the bandwidth-estimation-from-disk example to use the simplified callback-less API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 4/4 of a cross-repository series.
Part 1 is pion/interceptor#297
Part 2 is #3002
Part 3 is pion/interceptor#298
Please don't merge until I've had a chance to test it in Galene.
@Sean-Der Please let me know if you agree with the principle, so I can start working on making Galene use this interface. Even if you approve, I won't merge until I've convinced myself that it works for Galene.