Correct notification routing for DEPLOYMENT_STARTED (#5523)

* Correct notification routing for `DEPLOYMENT_STARTED` Signed-off-by: Yuki Okushi <[email protected]> * Harden test case Signed-off-by: Yuki Okushi <[email protected]> --------- Signed-off-by: Yuki Okushi <[email protected]>
pipe-cd · Jan 31, 2025 · 3021db1 · 3021db1
1 parent 7262a8c
commit 3021db1
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/pkg/app/piped/notifier/matcher_test.go b/pkg/app/piped/notifier/matcher_test.go
@@ -148,6 +148,22 @@ func TestMatch(t *testing.T) {
 						},
 					},
 				}: true,
+				{
+					Type: model.NotificationEventType_EVENT_DEPLOYMENT_STARTED,
+					Metadata: &model.NotificationEventDeploymentStarted{
+						Deployment: &model.Deployment{
+							ApplicationName: "bluegreen",
+						},
+					},
+				}: false,
+				{
+					Type: model.NotificationEventType_EVENT_DEPLOYMENT_STARTED,
+					Metadata: &model.NotificationEventDeploymentStarted{
+						Deployment: &model.Deployment{
+							ApplicationName: "canary",
+						},
+					},
+				}: true,
 			},
 		},
 		{
@@ -261,6 +277,28 @@ func TestMatch(t *testing.T) {
 						},
 					},
 				}: true,
+				{
+					Type: model.NotificationEventType_EVENT_DEPLOYMENT_STARTED,
+					Metadata: &model.NotificationEventDeploymentStarted{
+						Deployment: &model.Deployment{
+							Labels: map[string]string{
+								"env":  "stg",
+								"team": "pipecd",
+							},
+						},
+					},
+				}: false,
+				{
+					Type: model.NotificationEventType_EVENT_DEPLOYMENT_STARTED,
+					Metadata: &model.NotificationEventDeploymentStarted{
+						Deployment: &model.Deployment{
+							Labels: map[string]string{
+								"env":  "dev",
+								"team": "pipecd",
+							},
+						},
+					},
+				}: true,
 			},
 		},
 	}

diff --git a/pkg/model/notificationevent.go b/pkg/model/notificationevent.go
@@ -108,6 +108,14 @@ func (e *NotificationEventDeploymentTriggerFailed) GetLabels() map[string]string
 	return e.Application.Labels
 }
 
+func (e *NotificationEventDeploymentStarted) GetAppName() string {
+	return e.Deployment.ApplicationName
+}
+
+func (e *NotificationEventDeploymentStarted) GetLabels() map[string]string {
+	return e.Deployment.Labels
+}
+
 func (e *NotificationEventApplicationSynced) GetAppName() string {
 	return e.Application.Name
 }