Use valid semver in run/pipecd command (#4851)

* Use valid semver in run/pipecd command Signed-off-by: David <[email protected]> * Swapped to simpler local version Signed-off-by: David Gannon <[email protected]> * Include a comment explaining why we hard coded Signed-off-by: David Gannon <[email protected]> --------- Signed-off-by: David <[email protected]> Signed-off-by: David Gannon <[email protected]>
pipe-cd · Apr 13, 2024 · cfeac53 · cfeac53
1 parent 4436527
commit cfeac53
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -97,7 +97,10 @@ test/integration:
 
 .PHONY: run/pipecd
 run/pipecd: $(eval TIMESTAMP = $(shell date +%s))
-run/pipecd: BUILD_VERSION ?= "$(shell git describe --tags --always --abbrev=7)-$(TIMESTAMP)"
+# NOTE: previously `git describe --tags` was used to determine the version for running locally
+# However, this does not work on a forked branch, so the decision was made to hardcode at version 0.0.0
+# see: https://github.com/pipe-cd/pipecd/issues/4845
+run/pipecd: BUILD_VERSION ?= "v0.0.0-$(shell git rev-parse --short HEAD)-$(TIMESTAMP)"
 run/pipecd: BUILD_COMMIT ?= $(shell git rev-parse HEAD)
 run/pipecd: BUILD_DATE ?= $(shell date -u '+%Y%m%d-%H%M%S')
 run/pipecd: BUILD_LDFLAGS_PREFIX := -X github.com/pipe-cd/pipecd/pkg/version