Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add pipectl init #4763

Merged
merged 7 commits into from
Feb 1, 2024
Merged

[doc] Add pipectl init #4763

merged 7 commits into from
Feb 1, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jan 31, 2024

What this PR does / why we need it:

  • Add feature statuses for pipectl init
  • Add an explanation of pipectl init in the CLI page

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?: no

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3c72f4a) 31.03% compared to head (23be1e2) 31.06%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/app/pipectl/cmd/initialize/initialize.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4763      +/-   ##
==========================================
+ Coverage   31.03%   31.06%   +0.02%     
==========================================
  Files         225      225              
  Lines       26257    26257              
==========================================
+ Hits         8150     8156       +6     
+ Misses      17457    17451       -6     
  Partials      650      650              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Added a comment!

Comment on lines 315 to 318
### Generating an application config (app.pipecd.yaml)

Generate an app.pipecd.yaml interactively:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] It would be nice to add the link to the Feature Status page for pipectl init 👀
So users can easily understand what kinds of apps are supported currently :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ffjlabo
Thanks! I added some links!

khanhtc1202
khanhtc1202 previously approved these changes Jan 31, 2024
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@khanhtc1202 khanhtc1202 merged commit c2bc69f into master Feb 1, 2024
13 of 14 checks passed
@khanhtc1202 khanhtc1202 deleted the doc-pipectl-status branch February 1, 2024 14:05
t-kikuc added a commit that referenced this pull request Feb 2, 2024
* Add pipectl init status

Signed-off-by: t-kikuc <[email protected]>

* add init cmd to pipectl doc

Signed-off-by: t-kikuc <[email protected]>

* add pipectl init explanation

Signed-off-by: t-kikuc <[email protected]>

* fi pipectl init status

Signed-off-by: t-kikuc <[email protected]>

* add link to feature status

Signed-off-by: t-kikuc <[email protected]>

* fix link to feature status

Signed-off-by: t-kikuc <[email protected]>

* Add link to command-line-tool

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants