Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add NOTE for ECS ELB Listeners #4766

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[doc] Add NOTE for ECS ELB Listeners #4766

merged 2 commits into from
Feb 2, 2024

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Jan 31, 2024

What this PR does / why we need it:

To inform how ECS deployments work, especially ELB ListenerRules.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?: no

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c72f4a) 31.03% compared to head (83add30) 31.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4766   +/-   ##
=======================================
  Coverage   31.03%   31.03%           
=======================================
  Files         225      225           
  Lines       26257    26257           
=======================================
  Hits         8150     8150           
  Misses      17457    17457           
  Partials      650      650           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t-kikuc t-kikuc self-assigned this Feb 1, 2024
@khanhtc1202 khanhtc1202 merged commit 67562cb into master Feb 2, 2024
14 checks passed
@khanhtc1202 khanhtc1202 deleted the doc-ecs-listener branch February 2, 2024 04:06
t-kikuc added a commit that referenced this pull request Feb 2, 2024
* Add doc NOTE for ECS ELB Listeners

Signed-off-by: t-kikuc <[email protected]>

* Fix typo in doc

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants