Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gc.autoDetach by default #4772

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Disable gc.autoDetach by default #4772

merged 1 commit into from
Feb 2, 2024

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Feb 2, 2024

What this PR does / why we need it:

Set gc.autoDetach to false by default.
I mistook the default value, not true but false on PR #4761

Which issue(s) this PR fixes:

Fixes #4760

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo
Copy link
Member Author

ffjlabo commented Feb 2, 2024

✅ tested the behavior of cloning a repo, especially with pipectl plan-preview on local

received a plan-preview command to handle	{"command": "c9812ced-0b8e-4acc-9d91-ae3ebce48e6c"}
start building planpreview result for command c9812ced-0b8e-4acc-9d91-ae3ebce48e6c	{"command": "c9812ced-0b8e-4acc-9d91-ae3ebce48e6c"}
cloning ffjlabo-dev for the first time	{"repo-id": "ffjlabo-dev", "remote": "XXX", "repo-cache-path": "/var/folders/th/pq_q9v6j6_n_0fgx6v1_zp09_2tx_x/T/gitcache4050105689/ffjlabo-dev"}
cloning a repo from cached one in local	{"repo-id": "ffjlabo-dev", "remote": "XXX", "repo-cache-path": "/var/folders/th/pq_q9v6j6_n_0fgx6v1_zp09_2tx_x/T/gitcache4050105689/ffjlabo-dev", "src": "/var/folders/th/pq_q9v6j6_n_0fgx6v1_zp09_2tx_x/T/gitcache4050105689/ffjlabo-dev", "dst": "/var/folders/th/pq_q9v6j6_n_0fgx6v1_zp09_2tx_x/T/plan-preview-builder-3616880621/2748758883"}
setting gc.autoDetach	{"repo-id": "ffjlabo-dev", "remote": "XXX", "repo-cache-path": "/var/folders/th/pq_q9v6j6_n_0fgx6v1_zp09_2tx_x/T/gitcache4050105689/ffjlabo-dev", "gc.autoDetach": false}
successfully reported a failure command	{"command": "c9812ced-0b8e-4acc-9d91-ae3ebce48e6c"}

git config of the repo cloned for plan-preview↓

% cd /var/folders/th/pq_q9v6j6_n_0fgx6v1_zp09_2tx_x/T/plan-preview-builder-3616880621/2748758883
% git config --get gc.autoDetach                                                                                   
false

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea9a453) 31.02% compared to head (5f2c792) 31.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4772   +/-   ##
=======================================
  Coverage   31.02%   31.02%           
=======================================
  Files         225      225           
  Lines       26353    26353           
=======================================
  Hits         8175     8175           
  Misses      17525    17525           
  Partials      653      653           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo ffjlabo enabled auto-merge (squash) February 2, 2024 07:28
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ffjlabo ffjlabo merged commit 5cca5e7 into master Feb 2, 2024
14 checks passed
@ffjlabo ffjlabo deleted the disable-gc-autoDetach branch February 2, 2024 07:38
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable to execute 'git gc' in the foreground
3 participants