-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable gc.autoDetach by default #4772
Conversation
Signed-off-by: Yoshiki Fujikane <[email protected]>
✅ tested the behavior of cloning a repo, especially with pipectl plan-preview on local
git config of the repo cloned for plan-preview↓
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4772 +/- ##
=======================================
Coverage 31.02% 31.02%
=======================================
Files 225 225
Lines 26353 26353
=======================================
Hits 8175 8175
Misses 17525 17525
Partials 653 653 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
What this PR does / why we need it:
Set gc.autoDetach to false by default.
I mistook the default value, not true but false on PR #4761
Which issue(s) this PR fixes:
Fixes #4760
Does this PR introduce a user-facing change?: