Relocate plugin proto #4826
Merged
Relocate plugin proto #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <[email protected]>
khanhtc1202
requested review from
nghialv,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
ffjlabo
reviewed
Mar 13, 2024
pkg/plugin/platform/api/api.proto
Outdated
| package grpc.pluggin.applicationkind; | ||
| option go_package = "github.com/pipe-cd/pipecd/pkg/app/pipedv1/pluggin/applicationkind/api"; | ||
| package grpc.plugin.platformapi; | ||
| option go_package = "github.com/pipe-cd/pipecd/pkg/plugin/platform/platformapi"; |
There was a problem hiding this comment.
Suggested change
| option go_package = "github.com/pipe-cd/pipecd/pkg/plugin/platform/platformapi"; | |
| option go_package = "github.com/pipe-cd/pipecd/pkg/plugin/platform/api"; |
There was a problem hiding this comment.
we're going to have /stage/api, so I guess we want this package named as platformapi instead of api, or we have to use import aliases each time we import both. wdyt?
There was a problem hiding this comment.
@khanhtc1202
I got your point. So how about this? /api/platform and /api/stage like googleapis.
https://github.com/googleapis/googleapis/tree/master/google/api/serviceusage/v1
We can avoid using the import aliases. Also, we can do versioning as /api/platform/v1 when we fix the plugin API.
There was a problem hiding this comment.
Nice point, let's me adopt this 👍
There was a problem hiding this comment.
Ah, also we might consider about the plugin versioning like /plugin/v1alpha1/api 👀
WDYT?
There was a problem hiding this comment.
Also, ref: k8s versioning https://kubernetes.io/docs/reference/using-api/#api-versioning
There was a problem hiding this comment.
📝 talked outside github: We decided to use /plugin/api/v1alpha1/platform to do versioning only the package exposed for the users.
t-kikuc
previously approved these changes
Mar 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4826 +/- ##
=======================================
Coverage 28.91% 28.91%
=======================================
Files 317 317
Lines 40333 40333
=======================================
Hits 11662 11662
Misses 27743 27743
Partials 928 928 ☔ View full report in Codecov by Sentry. |
Signed-off-by: khanhtc1202 <[email protected]>
t-kikuc
approved these changes
Mar 13, 2024
ffjlabo
approved these changes
Mar 13, 2024
Merged
t-kikuc
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: khanhtc1202 <[email protected]>
t-kikuc
pushed a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: khanhtc1202 <[email protected]>
t-kikuc
added a commit
that referenced
this pull request
Apr 8, 2024
* BUGFIX: Added cancel method to fix context leak (#4767) Signed-off-by: fazledyn-or <[email protected]> * Define piped pluggin api (#4815) Signed-off-by: khanhtc1202 <[email protected]> * Update BuldPlan API for piped pluggin (#4821) Signed-off-by: khanhtc1202 <[email protected]> * Relocate plugin proto (#4826) Signed-off-by: khanhtc1202 <[email protected]> * Update controller to use new planner logic (#4825) * Update controller to use new planner logic Signed-off-by: khanhtc1202 <[email protected]> * Update proto path Signed-off-by: khanhtc1202 <[email protected]> * Fix typo Signed-off-by: khanhtc1202 <[email protected]> * Fix typo Signed-off-by: khanhtc1202 <[email protected]> * Update planner logic to call proto instead of self executing Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> * Update plugin proto for ExecutorService and add piped pluginservice (#4834) * Add plugin planner for k8s (#4819) * [WIP] Add planner Signed-off-by: Yoshiki Fujikane <[email protected]> * Not to use out.Version Signed-off-by: Yoshiki Fujikane <[email protected]> * Use last_successful_commit_hash and last_successful_config_file_name Signed-off-by: Yoshiki Fujikane <[email protected]> * Use in.WorkingDir Signed-off-by: Yoshiki Fujikane <[email protected]> * Use in.PipedConfig Signed-off-by: Yoshiki Fujikane <[email protected]> * Create git client Signed-off-by: Yoshiki Fujikane <[email protected]> * Create secret encryptor Signed-off-by: Yoshiki Fujikane <[email protected]> * Add startup server implementation Signed-off-by: Yoshiki Fujikane <[email protected]> * Fix for relocation of proto api Signed-off-by: Yoshiki Fujikane <[email protected]> * Add roughly implementation for planner plugin Signed-off-by: Yoshiki Fujikane <[email protected]> * Rename pkg name Signed-off-by: Yoshiki Fujikane <[email protected]> * Add licence Signed-off-by: Yoshiki Fujikane <[email protected]> * Comment out for the testing code Signed-off-by: Yoshiki Fujikane <[email protected]> --------- Signed-off-by: Yoshiki Fujikane <[email protected]> * Truncate `deploymentStatus` metrics after reporting stats (#4857) * Truncate deploymentStatus metrics after reporting to avoid excess message size Signed-off-by: t-kikuc <[email protected]> * Rename func to Flush() for clarity Signed-off-by: t-kikuc <[email protected]> * Add comment of what's included in statsreporter's body Signed-off-by: t-kikuc <[email protected]> * Fix indent in the comment Signed-off-by: t-kikuc <[email protected]> * Copy change of metrics.go to pipedv1 Signed-off-by: t-kikuc <[email protected]> * Copy change of reporter.go to pipedv1 Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: fazledyn-or <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: t-kikuc <[email protected]> Co-authored-by: Ataf Fazledin Ahamed <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Apr 18, 2024
Signed-off-by: khanhtc1202 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: