[doc] Add links to each README.md of components #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4828 +/- ##
==========================================
+ Coverage 28.90% 28.92% +0.02%
==========================================
Files 317 317
Lines 40333 40333
==========================================
+ Hits 11658 11668 +10
+ Misses 27746 27737 -9
+ Partials 929 928 -1 ☔ View full report in Codecov by Sentry. |
|
@t-kikuc I think we should add links to launcher and pipectl readme as well. Even it's blank, we can be aware those README exist and update later 😄 |
Signed-off-by: t-kikuc <[email protected]>
|
@khanhtc1202 Thanks, I fixed |
|
@ffjlabo plz |
ffjlabo
approved these changes
Mar 15, 2024
Merged
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Apr 18, 2024
* Add link to each README.md of pipecd,piped Signed-off-by: t-kikuc <[email protected]> * Add link to each README.md of web,docs Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Developers can easily look up how to build pipecd/piped.