Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4563 - Disable warnings for deprecations that come from Jakarta specification dependencies #4571

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fixes #4563 - Disable warnings for deprecations that come from Jakarta specification dependencies #4571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/impl/src/main/java/cloud/piranha/core/impl/DefaultHttpSessionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ public String encodeURL(HttpServletResponse response, String url) {
}

@Override
@SuppressWarnings("removal")
public String getComment() {
return comment;
}
Expand Down
5 changes: 2 additions & 3 deletions ...selink/src/main/java/cloud/piranha/extension/eclipselink/EntityManagerFactoryCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
*/
package cloud.piranha.extension.eclipselink;

import static jakarta.persistence.spi.PersistenceUnitTransactionType.JTA;

import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.HashSet;
Expand Down Expand Up @@ -103,6 +101,7 @@ public EntityManagerFactory get(String unitName) {
return entityManagerFactories.computeIfAbsent(unitName, this::create);
}

@SuppressWarnings("removal")
private EntityManagerFactory create(String unitName) {
Map<Object, Object> properties = new HashMap<>();

Expand All @@ -122,7 +121,7 @@ private EntityManagerFactory create(String unitName) {
throw new IllegalStateException("No persistence unit found for [" + unitName + "]");
}

persistenceUnitInfo.setTransactionType(JTA);
persistenceUnitInfo.setTransactionType(jakarta.persistence.spi.PersistenceUnitTransactionType.JTA);

if (persistenceUnitInfo.getJtaDataSource() != null && persistenceUnitInfo.getJtaDataSource().getClass().getName().equals("org.eclipse.persistence.internal.jpa.jdbc.DataSourceImpl")) {
for (Method method : persistenceUnitInfo.getJtaDataSource().getClass().getDeclaredMethods()) {
Expand Down
Loading