Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssl enabled property in Redis config for Spring Boot 3.1 #254

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

AmiDavidW
Copy link
Contributor

@anthonydahanne
Copy link
Member

Yes, I can confirm the deprecation of the property
https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.1.0-RC2-Configuration-Changelog

@pivotal-david-osullivan : if you don't use the new properties in Spring Boot 3.1+, you get this error:

Caused by: org.springframework.boot.context.properties.bind.BindException: Failed to bind properties under 'spring.data.redis.ssl' to org.springframework.boot.autoconfigure.data.redis.RedisProperties$Ssl

So I suggest we incorporate this change the sooner.

@anthonydahanne
Copy link
Member

ok, now it's even rebased!
it was tested manually also using the integration test we have that uses Redis!

@anthonydahanne anthonydahanne merged commit c63e948 into pivotal-cf:main Aug 12, 2024
1 check passed
@anthonydahanne
Copy link
Member

thanks @AmiDavidW for your contribution, it's in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants