Skip fields without content from result. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOddLinguist
pushed a commit
to TheOddLinguist/presskit.html
that referenced
this pull request
Jul 30, 2019
Copied from pixelnest#8
|
Any interest in getting this merged? Would be great to have without fiddling with the npm package. |
lib/core/builder.js
Outdated
| @@ -86,6 +108,11 @@ async function build (dataFilePath, presskit, { | |||
| return path.relative(buildFolder, htmlFilePath) | |||
| } | |||
|
|
|||
| //Check if a var exists or it's valid | |||
There was a problem hiding this comment.
The missing space after // yields a lint error that fails test.
Added missing comment space
|
Actually, there were 4 errors, now 3 left: I'm interested in seeing this PR merged as I have a similar need :-) |
Fixed issues: 112:23 error Missing space before function parentheses 113:24 error Expected '!==' and instead saw '!=' 113:27 error Strings must use singlequote
|
@solarsailer any chance to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
before:
https://i.imgur.com/AhCHR9G.png
after:
https://i.imgur.com/5yqGEEl.png